Skip to content

CNV-87529: management: add alert rule classification system#976

Open
sradco wants to merge 1 commit into
openshift:main-alerts-management-apifrom
sradco:alert-mgmt-restructured-04-classification
Open

CNV-87529: management: add alert rule classification system#976
sradco wants to merge 1 commit into
openshift:main-alerts-management-apifrom
sradco:alert-mgmt-restructured-04-classification

Conversation

@sradco

@sradco sradco commented Jun 8, 2026

Copy link
Copy Markdown

Add classification labels (component,
layer) for alert rules with validation,
ARC-based persistence, and bulk update
support.

Signed-off-by: Shirly Radco [email protected]
Signed-off-by: João Vilaça [email protected]
Signed-off-by: Aviv Litman [email protected]
Co-authored-by: AI Assistant [email protected]

Made with Cursor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 8, 2026

Copy link
Copy Markdown

@sradco: This pull request references CNV-80608 which is a valid jira issue.

Details

In response to this:

Add classification labels (component,
layer) for alert rules with validation,
ARC-based persistence, and bulk update
support.

Signed-off-by: Shirly Radco [email protected]
Signed-off-by: João Vilaça [email protected]
Signed-off-by: Aviv Litman [email protected]
Co-authored-by: AI Assistant [email protected]

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from PeterYurkovich and zhuje June 8, 2026 14:23
@sradco sradco changed the title CNV-80608: management: add alert rule classification system CNV-87529: management: add alert rule classification system Jun 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 8, 2026

Copy link
Copy Markdown

@sradco: This pull request references CNV-87529 which is a valid jira issue.

Details

In response to this:

Add classification labels (component,
layer) for alert rules with validation,
ARC-based persistence, and bulk update
support.

Signed-off-by: Shirly Radco [email protected]
Signed-off-by: João Vilaça [email protected]
Signed-off-by: Aviv Litman [email protected]
Co-authored-by: AI Assistant [email protected]

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sradco

sradco commented Jun 9, 2026

Copy link
Copy Markdown
Author

/retest

Comment thread docs/alert-rule-classification.md
Comment thread docs/alert-rule-classification.md Outdated
Comment thread pkg/classification/validation.go Outdated
Comment thread pkg/management/update_classification.go
Comment thread pkg/management/update_classification.go
Comment thread pkg/management/update_classification.go
Comment thread docs/alert-rule-classification.md
Comment thread pkg/management/update_classification.go
Comment thread docs/alert-rule-classification.md Outdated
Add classification labels (component,
layer) for alert rules with validation,
ARC-based persistence, and bulk update
support.

Signed-off-by: Shirly Radco <[email protected]>
Signed-off-by: João Vilaça <[email protected]>
Signed-off-by: Aviv Litman <[email protected]>
Co-authored-by: AI Assistant <[email protected]>
Co-authored-by: Cursor <[email protected]>
@sradco sradco force-pushed the alert-mgmt-restructured-04-classification branch from 8f0202e to 6268b33 Compare June 16, 2026 12:02
@PeterYurkovich

Copy link
Copy Markdown
Contributor

/lgtm

@PeterYurkovich

Copy link
Copy Markdown
Contributor

/hold
hold for Simon's review

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 16, 2026
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2026
@sradco

sradco commented Jun 16, 2026

Copy link
Copy Markdown
Author

@simonpasquier Please review this PR. Thank you.

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@sradco: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants